DaanHoogland opened a new pull request, #14562: URL: https://github.com/apache/cloudstack/pull/14562
Depends on https://github.com/apache/cloudstack/pull/14561 ### Description Stack for #12316 (StorageManager tech debt), one PR per item of the issue checklist, review only the top commit of each: 1. #13598: unused methods, fields and return values 2. never-thrown checked exceptions 3. raw types and unchecked casts 4. never-used parameters 5. remaining trivial warnings **This PR (5/5)** handles the remaining trivial warnings in `StorageManagerImpl` and the storage commands: - parameterised logging instead of `String.format` and string concatenation - `isEmpty()` and `CollectionUtils` instead of `size() > 0`, and simplified boolean and redundant-initialiser code - removes redundant `logger.isDebugEnabled()` guards around parameterised calls. Guards that protect eagerly computed `toHumanReadableSize()` arguments stay. - drops `required = false` (the default) and reformats long `@Parameter` annotations Out of scope: the `Config` deprecation warnings (#10752 / #14467) and `SearchCriteria.addAnd` deprecations. Fixes: #12316 ### Types of changes - [x] Cleanup (Code refactoring and cleanup, that may add test cases) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
