Copilot commented on code in PR #13598:
URL: https://github.com/apache/cloudstack/pull/13598#discussion_r4443839621
##########
engine/components-api/src/main/java/com/cloud/storage/StorageManager.java:
##########
@@ -340,11 +332,9 @@ static Boolean getFullCloneConfiguration(Long storeId) {
boolean canHostPrepareStoragePoolAccess(Host host, StoragePool pool);
- boolean canDisconnectHostFromStoragePool(Host host, StoragePool pool);
-
Host getHost(long hostId);
- Host updateSecondaryStorage(long secStorageId, String newUrl);
+ void updateSecondaryStorage(long secStorageId, String newUrl);
Review Comment:
Changing `updateSecondaryStorage` from returning `Host` to `void` is a
binary-incompatible change for downstream consumers (return type is part of the
method signature in the JVM). If you need to preserve compatibility, keep the
`Host` return type (callers can still ignore it) or introduce a new method name
(e.g., `void updateSecondaryStorageUrl(...)`) and deprecate the old method
until the next major version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
