saurabhkushwaha438 commented on code in PR #14413:
URL: https://github.com/apache/cloudstack/pull/14413#discussion_r4444648179
##########
ui/src/views/compute/wizard/ComputeSelection.vue:
##########
@@ -241,18 +315,37 @@ export default {
updateComputeCpuSpeed (value) {
this.$emit('update-compute-cpuspeed', this.cpuSpeedInputDecorator, value)
},
- updateComputeMemory (value) {
- if (!value) this.memoryInputValue = 0
- if (!this.validateInput('memory', value)) {
+ updateComputeMemory (displayValue) {
+ if (displayValue === null || displayValue === undefined || displayValue
=== '') {
+ this.memoryDisplayValue = 0
+ this.memoryInputValue = 0
+ } else {
+ this.memoryDisplayValue = displayValue
+ }
+ if (!this.validateInput('memory', displayValue)) {
return
}
- this.$emit('update-compute-memory', this.memoryInputDecorator, value)
+ let memoryInMiB
+ if (this.memoryUnit === 'GiB') {
Review Comment:
thanks for review , this is due ->
Incorrect memory conversion: An artificial boundary override caused 0.25 GiB
(256 MiB) to be treated as 100 MiB.
State synchronization: Switching between MiB and GiB didn't properly update
memoryInputValue or trigger memory updates.
i will work on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
