DaanHoogland opened a new pull request, #14561: URL: https://github.com/apache/cloudstack/pull/14561
Depends on https://github.com/apache/cloudstack/pull/14560 ### Description Stack for #12316 (StorageManager tech debt), one PR per item of the issue checklist, review only the top commit of each: 1. #13598: unused methods, fields and return values 2. never-thrown checked exceptions 3. raw types and unchecked casts 4. never-used parameters 5. remaining trivial warnings **This PR (4/5)** removes never-used parameters from non-framework methods: - `StorageManager.cleanupStorage(boolean recurring)` → `cleanupStorage()` (callers: `StorageManagerImpl`, `GarbageCollectingStoragePoolAllocator`) - `cleanupSecondaryStorage(boolean recurring)` → `cleanupSecondaryStorage()` - removes the stubs `sendToPool(long poolId, Command)` and `sendToPool(long poolId, Commands)`, which ignored both parameters, returned `null` and had no callers (every caller uses the `StoragePool` overloads) The remaining unused parameters belong to framework contracts (`configure`, `ClusterManagerListener`) and stay. Part of #12316 ### Types of changes - [x] Cleanup (Code refactoring and cleanup, that may add test cases) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
