Copilot commented on code in PR #13632:
URL: https://github.com/apache/cloudstack/pull/13632#discussion_r4444326364
##########
ui/package.json:
##########
@@ -104,16 +104,19 @@
"less-loader": "^5.0.0",
"nan": "2.18.0",
"node-gyp": "10.0.1",
- "sass": "^1.49.9",
+ "sass": "^1.101.0",
Review Comment:
This Sass upgrade makes the existing UI CI job incompatible: the resolved
`[email protected]` declares `engines.node >=20.19.0`, while
`.github/workflows/ui.yml` still runs `npm install`, `npm run build`, and the
tests on Node 16. The install may only warn, but the build invokes this Sass
version and can fail at runtime; please update the CI/build environments to the
supported Node version or pin Sass (and its lockfile entry) to a release that
still supports Node 16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
