DaanHoogland opened a new pull request, #14556: URL: https://github.com/apache/cloudstack/pull/14556
Depends on https://github.com/apache/cloudstack/pull/14555 ### Description Third PR of the stack: the code-style cleanups that were mixed into an earlier version of #12500, split out so they can be reviewed (or declined) on their own. **Based on the Ovm/Ovm3 PR; review only the last commit.** Files: `ApiResponseHelper`, `Upgrade410to420`, `AffinityGroupServiceImpl`, `SystemVmTemplateRegistration`. Mostly mechanical: diamond operators, logger placeholders, redundant try-with-resources semicolons, `isEmpty()`, multi-catch. Changes that go beyond that: - `ApiResponseHelper`: several capability/service response blocks are extracted into private static helpers. Two commented-out `createUserVmResponse` overloads are deleted. - `Upgrade410to420`: the string `if/else` chains become `switch` statements (same null behaviour as the `.equals()` calls they replace). The unused `dropUploadTable()` and the `supportsRollingUpgrade()` override are removed (the interface default also returns `false`). Repeated messages become constants. Note: `Upgrade410to420` is a historic upgrade path, so the changes there buy little and some reviewers may prefer to leave it alone. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
