zheng1771 opened a new pull request, #14614: URL: https://github.com/apache/cloudstack/pull/14614
### Description Check access to the UserData selected by cniconfigurationid before creating a Kubernetes cluster. Add @ACL to the API parameter, matching other UserData parameters. Also validate the reference in the cluster service: reject a missing record and check caller access before cluster creation proceeds. An omitted CNI configuration is still allowed. Existing cluster references are not changed. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [x] Critical - [ ] Major - [ ] Minor - [ ] Trivial The selected UserData must be accessible to the caller. ### Screenshots (if appropriate): Not applicable. Backend change. ### How Has This Been Tested? All 33 KubernetesClusterManagerImplTest tests and 13 ParamProcessWorkerTest tests passed. Required modules compiled and Checkstyle passed. <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? Added regression tests for: - An omitted CNI configuration. - An accessible UserData reference. - An inaccessible UserData reference passed to cluster creation. - A missing UserData reference passed to cluster creation. Rejected requests stop before cluster persistence or further cluster parameter processing. Existing API parameter access-check tests also passed. <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
