JoaoJandre commented on code in PR #13939:
URL: https://github.com/apache/cloudstack/pull/13939#discussion_r4479909401
##########
engine/schema/src/main/resources/META-INF/db/schema-42300to2400.sql:
##########
@@ -19,6 +19,26 @@
-- Schema upgrade from 4.23.0.0 to 24.0.0
--;
+-- Backup report
+
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.backups', 'failure_reason',
'varchar(255)');
Review Comment:
The idea is to limit the amount of text that is stored. I want to avoid
storing large stack traces or things like that in the DB. I think it is best if
we leave it capped at 255, messages larger than this should be in the logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
