weizhouapache commented on PR #14285:
URL: https://github.com/apache/cloudstack/pull/14285#issuecomment-6738560764

   > > > @weizhouapache , why is this needed? And will this have upgrade 
consequences? I.E. `ConsoleAccesManager` and `ResourceCleanupService` and maybe 
others, already have configuration items by their full names.
   > > 
   > > 
   > > because all other configurations use simple class names as component. I 
did not see regression after upgrade
   > 
   > so `Advanced DEFAULT 
org.apache.cloudstack.consoleproxy.ConsoleAccessManager 
console.session.cleanup.interval 180 Determines the interval (in hours) to wait 
between the console session cleanup tasks 180 2026-10-06 11:39:10.000 0 7 23 
Console session cleanup interval 1`, gets updated to use a short name? i.e. 
upgrade testing needed.
   
   yes, component will be "ConsoleAccessManager"
   
   ```
   mysql> select category,name,component,value from configuration where 
name='console.session.cleanup.interval' \G
   *************************** 1. row ***************************
    category: Advanced
        name: console.session.cleanup.interval
   component: org.apache.cloudstack.consoleproxy.ConsoleAccessManager   
<------- will be "ConsoleAccessManager"
       value: 180
   1 row in set (0.00 sec)
   ```
   
   from what I know, the `component` is not used to get the value of setting 
(only `name` is used)
   for sure we can run upgrade testing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to