winterhazel commented on code in PR #14192:
URL: https://github.com/apache/cloudstack/pull/14192#discussion_r4513015591
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/IscsiAdmStorageAdaptor.java:
##########
@@ -148,137 +153,24 @@ public boolean connectPhysicalDisk(String volumeUuid,
KVMStoragePool pool, Map<S
// After a certain number of tries and a certain waiting period in
between tries,
// this method could still return (it should not block indefinitely)
(the race condition
// isn't solved here, but made highly unlikely to be a problem).
- // If the by-path is missing or is a regular file (not the iSCSI block
symlink), size
- // stays 0. Return false so connect does not succeed and a raw file is
not created at
- // that by-path in place of the real LUN device.
- if (!waitForDiskToBecomeAvailable(volumeUuid, pool)) {
- logger.warn("iSCSI device not ready for target {} at {}:{} after
wait", volumeUuid, host, port);
- return false;
- }
+ waitForDiskToBecomeAvailable(volumeUuid, pool);
return true;
}
- /**
- * Checks the result of an iscsiadm node-create command.
- * Returns true if the node was created or already exists, false on
failure.
- */
- boolean handleNodeCreateResult(String result, String volumeUuid) {
Review Comment:
A few bug fixes and refactorings that #13897 made in this class are being
reverted. Is this intentional? If so, can we keep some of the generic fixes and
refactorings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
