bhouse-nexthop commented on code in PR #14623:
URL: https://github.com/apache/cloudstack/pull/14623#discussion_r4517150250
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtResizeVolumeCommandWrapper.java:
##########
@@ -120,7 +121,7 @@ public Answer execute(final ResizeVolumeCommand command,
final LibvirtComputingR
final LibvirtUtilitiesHelper libvirtUtilitiesHelper =
libvirtComputingResource.getLibvirtUtilitiesHelper();
final Connect conn =
libvirtUtilitiesHelper.getConnection();
- final StorageVol v = conn.storageVolLookupByPath(path);
Review Comment:
Done in
https://github.com/apache/cloudstack/pull/14623/commits/aa9683a36167f9565642c02c6a4c0ef533c27806:
the lookup with the RBD pool refresh is now
`LibvirtUtilitiesHelper.getStorageVolumeByPath(Connect, KVMStoragePool,
String)`, and the resize wrapper calls it. Its tests moved to
`LibvirtUtilitiesHelperTest`; `LibvirtComputingResourceTest` keeps the
end-to-end resize of an RBD volume libvirt has not cached, plus a resize that
fails when the lookup fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
