github-actions[bot] commented on issue #14626: URL: https://github.com/apache/cloudstack/issues/14626#issuecomment-6769042028
> [!WARNING] > threat detection engine error > The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding. > > <!-- gh-aw-threat-engine-error --> > > <details> > <summary>What happened</summary> > > The threat detection engine failed to produce results. > > Review the [workflow run logs](https://github.com/apache/cloudstack/actions/runs/42824790094) for details. > > </details> ## ๐ฏ Triage report If the system VM template step fails during a database upgrade, the schema steps are already marked `Complete`. On the next start the versions match, so the template step is never retried, and the management server runs the new version with the old system VM template settings. The reporter proposes two fixes: retry the template step on startup, or keep the last version row at `Cleanup` until the step succeeds. They ask for agreement on the approach first. ### ๐ Assessment | Dimension | Value | Reasoning | | --- | --- | --- | | **Type** | type:bug | The upgrade path leaves inconsistent state with no retry | | **Component** | component:upgrade, component:systemvm-template | `DatabaseUpgradeChecker` and template registration | | **Severity** | Severity:Major | Runs on the new version with old SSVM template settings; recovery needs a DB restore | | **Labels** | type:bug, component:upgrade, component:systemvm-template, Severity:Major | | | **Coding agent** | Needs more info | Two approaches with different trade-offs; a maintainer should choose one | ### ๐ Similar issues - #12077 (related) โ SystemVM template registration failure when upgrading to 4.22 - #12258 (related) โ systemVM template not downloaded in a multi-hypervisor environment - #9002 (related) โ default systemVM template not downloaded to S3 secondary storage <details> <summary>๐ก Notes and suggestions</summary> - Reproduction is in the report: rename the template or move the template file before the upgrade, then check the `version` table after the failed start. - Option 2 changes what `getCurrentVersion()` returns during a partial upgrade, so its callers and the downgrade path need review. </details> > Generated by [Daily Issue Triage](https://github.com/apache/cloudstack/actions/runs/42824790094) ยท copilot ยท haiku55 ยท \~5 AIC ยท โ 3.8K ยท [โท](https://github.com/search?q=repo%3Aapache%2Fcloudstack+%22gh-aw-workflow-call-id%3A+apache%2Fcloudstack%2Fdaily-issue-triage%22&type=issues) <details> <summary><sub>Add this agentic workflow to your repo</sub></summary> To install this agentic workflow, run ``` gh aw add githubnext/agentics/workflows/daily-issue-triage.md@139fa09ef17cde4135e696ff8e7af09bc5ddfa6e ``` </details> <!-- gh-aw-workflow-call-id: apache/cloudstack/daily-issue-triage --> <!-- gh-aw-agentic-workflow: Daily Issue Triage, engine: copilot, model: claude-haiku-5.5, id: 42824790094, workflow_id: daily-issue-triage, run: https://github.com/apache/cloudstack/actions/runs/42824790094 --> <!-- gh-aw-execution: {"version":1,"repo_id":"9759448","repository":"apache/cloudstack","aw_workflow_id":"daily-issue-triage","run_id":"42824790094","run_attempt":"1","run_url":"https://github.com/apache/cloudstack/actions/runs/42824790094","publishing_job":{"key":"safe_outputs","check_run_id":"129867538613"}} --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
