bhouse-nexthop commented on code in PR #14647:
URL: https://github.com/apache/cloudstack/pull/14647#discussion_r4528834257


##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1481,6 +1481,22 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws 
ResourceAllocationExcep
         }
     }
 
+    /**
+     * The resize orchestration (orchestrateResizeVolume) only tells the 
hypervisor about a running user VM. For a
+     * system VM the volume is resized on the storage, but the running guest 
is not told and keeps seeing the old size
+     * until it next starts. So a system VM's volume can only be resized while 
the system VM is stopped.
+     */
+    protected void validateVolumeIsNotOnRunningSystemVm(VolumeVO volume) {

Review Comment:
   @piyush5netapp agreed. It also refuses Starting, Stopping and Migrating, so 
"not running" undersold it. Renamed to `validateSystemVmIsStoppedForResize`, 
tests included, in f4a2abf4b1. `VolumeApiServiceImplTest` passes (150/150).
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to