github-actions[bot] commented on issue #14644: URL: https://github.com/apache/cloudstack/issues/14644#issuecomment-6802607957
> [!WARNING] > threat detection engine error > The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding. > > <!-- gh-aw-threat-engine-error --> > > <details> > <summary>What happened</summary> > > The threat detection engine failed to produce results. > > Review the [workflow run logs](https://github.com/apache/cloudstack/actions/runs/43029422543) for details. > > </details> ## 🎯 Triage report `revertSnapshot` fails with an NPE when the snapshot's volume has been deleted. `SnapshotManagerImpl.revertSnapshot` looks the volume up with `findById()`, which excludes removed rows, and then uses the result without a null check. The reporter also found that `copySnapshot` without `sourcezoneid` hits the same NPE, and that `createVolume` and `createTemplate` from a snapshot NPE when the volume row is missing entirely. The proposed fixes are a clear error for revert and create, and taking the source zone from the snapshot for copy. ### 📊 Assessment | Dimension | Value | Reasoning | | --- | --- | --- | | **Type** | type:bug | NPE in several snapshot APIs, with reproduction steps | | **Component** | component:snapshot | Failure is in snapshot manager lookups | | **Severity** | Severity:Minor | Only snapshots of deleted volumes; the API returns an internal error but no data is lost | | **Labels** | type:bug, component:snapshot, Severity:Minor | | | **Coding agent** | Suitable | Each API has a specified fix (clear error, or zone from snapshot) | ### 🔗 Similar issues - #14599 (related) — same class of NPE in snapshot strategy `canHandle()` when the volume row is missing <details> <summary>💡 Notes and suggestions</summary> - Reproduction: create a volume, take a snapshot, delete the volume, then call `revertSnapshot` and `copySnapshot` without `sourcezoneid`. - `createVolume` and `createTemplate` from a snapshot only fail when the volume row is gone, which is a different case from a removed volume. Check both. </details> > Generated by [Daily Issue Triage](https://github.com/apache/cloudstack/actions/runs/43029422543) · copilot · haiku55 · \~6 AIC · ⊞ 3.8K · [◷](https://github.com/search?q=repo%3Aapache%2Fcloudstack+%22gh-aw-workflow-call-id%3A+apache%2Fcloudstack%2Fdaily-issue-triage%22&type=issues) <details> <summary><sub>Add this agentic workflow to your repo</sub></summary> To install this agentic workflow, run ``` gh aw add githubnext/agentics/workflows/daily-issue-triage.md@139fa09ef17cde4135e696ff8e7af09bc5ddfa6e ``` </details> <!-- gh-aw-workflow-call-id: apache/cloudstack/daily-issue-triage --> <!-- gh-aw-agentic-workflow: Daily Issue Triage, engine: copilot, model: claude-haiku-5.5, id: 43029422543, workflow_id: daily-issue-triage, run: https://github.com/apache/cloudstack/actions/runs/43029422543 --> <!-- gh-aw-execution: {"version":1,"repo_id":"9759448","repository":"apache/cloudstack","aw_workflow_id":"daily-issue-triage","run_id":"43029422543","run_attempt":"1","run_url":"https://github.com/apache/cloudstack/actions/runs/43029422543","publishing_job":{"key":"safe_outputs","check_run_id":"130687254582"}} --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
