weizhouapache commented on code in PR #14667:
URL: https://github.com/apache/cloudstack/pull/14667#discussion_r4550510443
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1904,6 +1904,15 @@ private Pair<VolumeVO, DataStore>
recreateVolume(VolumeVO vol, VirtualMachinePro
return new Pair<>(newVol, destPool);
}
+ @Override
+ public void setUpVolumeEncryption(long volumeId, DiskOffering
diskOffering) {
+ if (diskOffering == null || !diskOffering.getEncrypt()) {
+ return;
+ }
+ VolumeVO volume = _volsDao.findById(volumeId);
+ setPassphraseForVolumeEncryption(volume);
Review Comment:
for main/24, this line should be
```
setPassphraseForVolumeEncryption(volume, getKmsKeyFromVolume(volume),
volume.getAccountId());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
