dheeraj12347 commented on code in PR #14493:
URL: https://github.com/apache/cloudstack/pull/14493#discussion_r4554006945
##########
test/integration/smoke/test_network_extension_namespace.py:
##########
@@ -2178,7 +2155,7 @@ def test_07_vpc_network_acl(self):
# This tests that the ACL egress rules work and inter-tier routing is
OK
try:
ssh_vm2 = SshClient(
- tier2_public_ip, 22, "ubuntu", None,
+ tier2_public_ip, 22, "debian", None,
keyPairFiles=self._ssh_private_key_file,
timeout=30, retries=10
)
Review Comment:
@weizhouapache and @harikrishna-patnala,
Could we add an explicit check for `FAILED` here, similar to the checks in
`test_network.py` and `test_ssl_offloading.py`?
`get_template()` returns `FAILED` when the template listing fails or returns
an empty/invalid response. Without checking this result, subsequent accesses to
`self.template.id` can raise an `AttributeError`, making the setup failure less
clear.
For consistency and clearer failure reporting, it would be helpful to assert
that the template was retrieved successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
