rafaelweingartner commented on a change in pull request #837: CLOUDSTACK-8855 
Improve Error Message for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/837#discussion_r118504187
 
 

 ##########
 File path: engine/components-api/src/com/cloud/agent/AgentManager.java
 ##########
 @@ -141,7 +142,7 @@
 
     public void pullAgentOutMaintenance(long hostId);
 
-    boolean reconnect(long hostId);
+    void reconnect(long hostId) throws CloudRuntimeException, 
AgentUnavailableException;
 
 Review comment:
   This is also another question, I do not see the benefit of declaring a 
runtime exception
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to