rafaelweingartner commented on a change in pull request #2124: CLOUDSTACK-9432:
cluster/host dedicated to a domain is owned by the root domain
URL: https://github.com/apache/cloudstack/pull/2124#discussion_r118733976
##########
File path:
server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java
##########
@@ -176,25 +176,31 @@ private void verifyAccessToDomainWideProcessor(Account
caller, AffinityGroupProc
}
}
- private AffinityGroupVO createAffinityGroup(final AffinityGroupProcessor
processor, final Account owner, final ACLType aclType, final String
affinityGroupName, final String affinityGroupType, final String description) {
+ private AffinityGroupVO createAffinityGroup(final AffinityGroupProcessor
processor, final Account owner, final ACLType aclType, final String
affinityGroupName, final String affinityGroupType, final String description,
boolean domainLevel, Long domainId) {
+
+ Long domainIdBasedOnDomainLevel = owner.getDomainId();
Review comment:
@GabrielBrascher what about extracting lines 181-184 to a method and then
create a test case for it?
Also a documentation describing the method seems a good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
