rafaelweingartner commented on a change in pull request #2113:
CLOUDSTACK-9162: Handled vpn user add when vpn is not enabled on the?
URL: https://github.com/apache/cloudstack/pull/2113#discussion_r118737442
##########
File path:
api/src/org/apache/cloudstack/api/command/user/vpn/AddVpnUserCmd.java
##########
@@ -124,7 +124,7 @@ public void execute() {
throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR,
"Failed to add vpn user");
}
}catch (Exception ex) {
Review comment:
@jayapalu do we need this catch-all here?
It seems that we can simply catch `ResourceUnavailableException`, and then
re-throw the exception.
Then, we do not need to do anything with the exception thrown at line 124
does, just let it go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
