The-Loeki commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-306782417 Aight, so wading through everything here I gots me the following: * The test results are either drowned in noise or not really descriptive of what's going wrong AFAICT * [@ustcweizhou suggestion](https://github.com/apache/cloudstack/pull/2089#issuecomment-302759739) seems sensible enough, so I basically did that * Considering code style consistency is apparently a thing (you wouldn't be able to tell from these blocks IMHO) I suggest you look into running (py)lint and https://www.shellcheck.net/ before approving a PR :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
