abhinandanprateek commented on a change in pull request #2135: [BLOCKER]
CLOUDSTACK-9860: Fix stackoverflow issue
URL: https://github.com/apache/cloudstack/pull/2135#discussion_r120806143
##########
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -2733,7 +2733,7 @@ public String stopVM(final Connect conn, final String
vmName, final boolean forc
if (forceStop) {
return stopVMInternal(conn, vmName, true);
}
- String ret = stopVM(conn, vmName, false);
+ String ret = stopVMInternal(conn, vmName, false);
if (ret == Script.ERR_TIMEOUT) {
ret = stopVMInternal(conn, vmName, true);
} else if (ret != null) {
Review comment:
if it is not force stop then any timeouts or resource exception should be
sent to the user. I think that is the valid legacy behaviour. Now if there is a
timeout instead of throwing exception the action will automatically get
converted to force shutdown @rhtyd @borisstoyanov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
