ustcweizhou commented on a change in pull request #2089: vRouters fixes & 
performance improvement
URL: https://github.com/apache/cloudstack/pull/2089#discussion_r121973386
 
 

 ##########
 File path: systemvm/patches/debian/config/opt/cloud/bin/update_config.py
 ##########
 @@ -52,15 +52,16 @@ def process(do_merge=True):
     qf.setFile(sys.argv[1])
     qf.do_merge = do_merge
     qf.load(None)
-
     return qf
 
 
 def process_file():
     print "[INFO] process_file"
     qf = process()
-    # Converge
-    finish_config()
+    # These can be safely deferred, dramatically speeding up loading times
+    if not (os.environ.get('DEFER_CONFIG', False) and sys.argv[1] in 
('vm_dhcp_entry.json', 'vm_metadata.json')):
 
 Review comment:
   @The-Loeki looked at the code again, the code is correct. 
   
   At the first sight I thought it is
   if not (os.environ.get('DEFER_CONFIG', False)) and sys.argv[1] in 
('vm_dhcp_entry.json', 'vm_metadata.json'):
   
   sorry for misunderstanding.
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to