rhtyd commented on a change in pull request #2177: CLOUDSTACK-9977: Enhance SSL
protocol used by Console Proxy
URL: https://github.com/apache/cloudstack/pull/2177#discussion_r128904170
##########
File path:
utils/src/main/java/org/apache/cloudstack/utils/security/SSLUtils.java
##########
@@ -49,10 +66,10 @@
}
public static SSLContext getSSLContext() throws NoSuchAlgorithmException {
- return SSLContext.getInstance("TLSv1");
+ return SSLContext.getInstance("TLSv1.2");
}
public static SSLContext getSSLContext(String provider) throws
NoSuchAlgorithmException, NoSuchProviderException {
- return SSLContext.getInstance("TLSv1", provider);
+ return SSLContext.getInstance("TLSv1.2", provider);
Review comment:
This might break clients (non-browser) for some cases where TLSv1.2 is not
supported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
