kishankavala commented on a change in pull request #2144: CLOUDSTACK-9955 :
Featured Templates/Iso's created by Root/admin user are not visible to Domain
Admin users
URL: https://github.com/apache/cloudstack/pull/2144#discussion_r129809062
##########
File path: server/src/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -3147,12 +3147,11 @@ private boolean isPermissible(Long accountDomainId,
Long offeringDomainId) {
ex.addProxyObject(template.getUuid(), "templateId");
throw ex;
}
- if (caller.getType() == Account.ACCOUNT_TYPE_DOMAIN_ADMIN) {
+ if (!template.isPublicTemplate() && !template.isFeatured() &&
caller.getType() == Account.ACCOUNT_TYPE_DOMAIN_ADMIN) {
Review comment:
@niteshsarda
!template.isFeatured() is not required here. Featured flag is not related to
template permission
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
