rhtyd commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms return uniform NIC data URL: https://github.com/apache/cloudstack/pull/2208#issuecomment-319925139 LGTM, no deletions in returned keys just additive changes. @DaanHoogland however a minor note, the comments may be indented, or just removed. I understand that it notes the sequence of keys, however that's not how the params/keys are serialized/returned in the api response. It just makes the code look bit weird IMO :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
