rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar URL: https://github.com/apache/cloudstack/pull/2226#issuecomment-323338821 @marcaurele I think we need to consider and discuss three things; - Whether to bundle the UI within the jar, or provider a webapp path to say /usr/share/cloudstack-management/webapp, in this directory we copy the UI asset files. This would allow admins to put their customizations. A solution could be to do both, so the fat jar has the UI files and however `ServerDaemon` would set the webapp path to the /usr path by default (if available) and fallback to assets in the jar when not found. - The DB files are kept out of the jar in case someone want to fix any upgrade failure issue. It's kind of subjective. My opinion is to bundle them in the jar, which reduces file management and opens scope for changes to the sql paths. - In addition, a lot of people may want to consume additional jars (plugins etc) which is why bounty castle and other jars may be put at `/usr/share/cloudstack-management/lib`. When mgmt server starts, we scan and include all the jars at this path in the classpath, with them first in the order in case someone want to overide any bundled jar etc. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
