rhtyd commented on a change in pull request #2213: CLOUDSTACK-10023: Windows
VMs with Multiple Nics fail to access internet
URL: https://github.com/apache/cloudstack/pull/2213#discussion_r134098642
##########
File path: server/src/com/cloud/network/router/CommandSetupHelper.java
##########
@@ -216,6 +220,15 @@ public void createDhcpEntryCommand(final VirtualRouter
router, final UserVm vm,
_networkModel.getExecuteInSeqNtwkElmtCmd());
String gatewayIp = nic.getIPv4Gateway();
+ if (!nic.isDefaultNic()) {
+ final GuestOSVO guestOS = _guestOSDao.findById(vm.getGuestOSId());
+ if (guestOS == null ||
!guestOS.getDisplayName().toLowerCase().contains("windows")) {
+ gatewayIp = "0.0.0.0";
Review comment:
@jayakarteek I'm not sure it's best to put a `0.0.0.0` as gateway IP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
