rhtyd commented on a change in pull request #2216: CLOUDSTACK-10027 Repeating
the same list for Internal LB in VPC
URL: https://github.com/apache/cloudstack/pull/2216#discussion_r134233469
##########
File path: ui/scripts/vpc.js
##########
@@ -745,8 +745,19 @@
}
},
dataProvider: function(args) {
+ var array1 = [];
+ if (args.filterBy != null) {
+ if (args.filterBy.search != null &&
args.filterBy.search.by != null && args.filterBy.search.value != null) {
+ switch (args.filterBy.search.by) {
+ case "name":
+ if (args.filterBy.search.value.length
> 0)
+ array1.push("&keyword=" +
args.filterBy.search.value);
+ break;
+ }
+ }
+ }
$.ajax({
- url: createURL('listLoadBalancers'),
+ url: createURL('listLoadBalancers&page=' +
args.page + '&pagesize=' + pageSize + array1.join("")),
Review comment:
@vedulasantosh instead of appending, move the key/values to data, like it is
with `vpcid`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
