DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957
Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r134981905
##########
File path: api/src/org/apache/cloudstack/api/BaseCmd.java
##########
@@ -192,6 +191,8 @@
public AlertService _alertSvc;
@Inject
public UUIDManager _uuidMgr;
+ @Inject
+ public AnnotationService annotationService;
Review comment:
As discussed, this is a breakage of pattern in the code base that goes two
ways. Adhering to one and not the other has downsides either way. Not important
now (in this PR) but worth revisiting is how to poetically describe used
services per API without having to describe the samething over and over per set
of API, i.e. the Annotation APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
