SudharmaJain commented on a change in pull request #2244: 
CLOUDSTACK-10054:Volume download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r137249664
 
 

 ##########
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ##########
 @@ -98,15 +98,16 @@
     @Override
     public boolean execute(VmwareHostService hostService, 
CreateEntityDownloadURLCommand cmd) {
         DataTO data = cmd.getData();
+        int timeout = 
NumbersUtil.parseInt(cmd.getContextParam(VmwareManager.s_vmwareOVAPackageTimeout.key()),
 3600000);
 
 Review comment:
   @mrunalinikankariya You can declare a  constant and use it in place of 
hardcoded integer(3600000) value. Same  can be used in other classes.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to