wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-330206218 @rhtyd: I did and it seems a different thing: <pre> ====================================================================== FAIL: Test that libvirt properly created domain with scsi controller ---------------------------------------------------------------------- Traceback (most recent call last): File "/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py", line 289, in test_01_verify_libvirt self.verifyVirshState(2) File "/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py", line 223, in verifyVirshState self.assertEqual(discard, "unmap", "discard settings not unmap") AssertionError: discard settings not unmap -------------------- >> begin captured stdout << --------------------- === TestName: test_01_verify_libvirt | Status : FAILED === </pre> If I look at the XML it seems that the discard setting isn't present either: ``` <disk type='file' device='disk'> <driver name='qemu' type='qcow2' cache='none'/> <source file='/mnt/9f9c91f2-d51a-3db0-b9d1-76fea13695ec/ec32f135-0f67-4289-873d-fc5f0465f5a1'/> <target dev='sda' bus='scsi'/> <serial>ec32f1350f674289873d</serial> <alias name='scsi0-0-0-0'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> ``` But that's not related to this PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
