rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID. URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-332726534 @jayantpatil1234 I've some general feedback: - Good work and initiative on refactoring the event/log output to export uuids instead of id - However, this does not solve the issue of standardising consumable output. For example, instead of fixing the string, we can refactor the core methods to accept objects and the core methods (in CallContext or other helper classes) can export json/xml/serializable formats. This can improve the ease of consuming event logs. - I've another suggestion, current events are tied to domain/accounts but not with entities such as VMs, Volumes, Hosts etc, maybe introduce a new db column in the event table that accepts a list of (related) entities to which the event statements be linked to. This can help unlock a new user experience and make it easier to search events tied to a resource, such as all events related to a VM, volume, host etc. This can be used in future to have a events tab for each such supported resources. As phase-1, the refactoring effort to move from ID to UUID looks okay to me, however, it still does not cover/fix all the cases where IDs are used instead of UUID in all the APIs. I would expect that with this large refactoring effort you may consider moving towards a small framework solution, where you export UUIDs and related objects and that framework/class is responsible for exporting the object to string, i.e. event description + entity (possibly in json etc). In CloudStack UI, the json may then be consumed to output the same sort of string like you see in the screenshots. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
