DaanHoogland commented on a change in pull request #2048: CLOUDSTACK-9880:
Expansion of Management IP Range.
URL: https://github.com/apache/cloudstack/pull/2048#discussion_r147059958
##########
File path: engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDao.java
##########
@@ -45,8 +45,11 @@
int countIPs(long dcId, boolean onlyCountAllocated);
+ int countIPs(String ipAddress, long podId, long dcId, boolean
onlyCountAllocated);
Review comment:
actually it doesn't. It can be one method that acts based upon the presence
of values in the parameters. i.e. if there is no ip present it searches for
ranges in pods/DCs and if an ip is present (not null) it checks for allocation.
If the behaviour is really distinct than so should the name. In that case i
suggest you rename it to isAllocatedInPodOrDc(), or maybe countIpAddressUsage()
or countIpAddressOccurance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
