bwsw commented on issue #2322: CLOUDSTACK-10140: Fix for when template is created from snapshot template.properties are corrupted URL: https://github.com/apache/cloudstack/pull/2322#issuecomment-345295039 Hi, @rafaelweingartner Basically, I started from this one: https://github.com/apache/cloudstack/pull/2320/files#diff-71901db20e3d4adb6711e69c1c1ca2ba it was found by @rhtyd and I fixed Id from 1 to actual code. I don't include it into PR because master already includes it. Next I went to debugging and opened the issue (CLOUDSTACK-10140) you saw in Jira. ``` root@cs2-secstorage-nfs1:/secondary/template/tmpl/2/209# cat template.properties uniquename=209-2-3accb15b-8647-356b-9791-9e2f1ec36b6b filename=bbab2601-050d-4c18-ae35-00f2ba44de28.qcow2 size=3254517760 qcow2.filename=bbab2601-050d-4c18-ae35-00f2ba44de28.qcow2 qcow2.virtualsize=10737418240 public=true id=1 ``` ID is fixed by code from 1st diff, but other information is incorrect including size (I don't see it in my snippet but AFAIK "size" field was incorrect and included something like UUID-like with "-"). Next, https://issues.apache.org/jira/secure/ViewProfile.jspa?name=weizhou user provided the patch and everything started to work fine. ~I suppose that ``` long size = _storage.getSize(destFileFullPath); ``` works incorrect.~ The actual fix works the next way: We write basic info on step one (first try block). Next, we configure format processor (second try block), like for qcow: ``` processor = new QCOW2Processor(); ``` which actually does the rest of things correctly. I think if basic format is incorrect the processor code stumbles upon it and unable to write the rest of the format. Frankly speaking, I didn't dive into details and it's a shame but It takes a lot of time to move across all the ACS code, because I'm not a "real" java developer. But this patch really works. I patched the 4.10, compiled, deployed into Agent, recreated SSVM and templates started to work properly. Basically, I recommend to consult Wei Zhou about his patch.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
