yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922:
Unable to delete IP tag
URL: https://github.com/apache/cloudstack/pull/905#discussion_r152729213
##########
File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java
##########
@@ -360,6 +348,53 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
return true;
}
+ private List<? extends ResourceTag> getResourceTags(final List<String>
resourceIds, ResourceObjectType resourceType) {
+
+ List<String> uuids = new ArrayList<String>();
+ List<String> internalIds = new ArrayList<String>();
+ for(String resourceId : resourceIds){
+
if(resourceId.matches("^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$")){
Review comment:
yes. But validating uuid also is possibly more foolproof
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
