mrunalinikankariya commented on a change in pull request #2292:
CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r152967096
##########
File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
##########
@@ -995,8 +994,8 @@ public boolean updateState(Status oldStatus, Event event,
Status newStatus, Host
}
}
if (event.equals(Event.ManagementServerDown)) {
- Float pingTimeout =
NumbersUtil.parseFloat(_configDao.getValue("ping.timeout"), 2.5f);
- Integer pingInterval =
NumbersUtil.parseInt(_configDao.getValue("ping.interval"), 60);
+ float pingTimeout =
(Float)_configDepot.get("ping.timeout").value();
Review comment:
@rhtyd
ConfigKeys can only be defined once so as it is already defined and used in
AgentManagerImpl, it can not be redefined. Also if you check the ConfigKeys, it
read the configuration from ConfigDepot only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
