rafaelweingartner commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-348136050 @khos2ow that is very interesting. They are indeed versioning this jar file. I always had Spring projects as an example of quality; I find versioning binary files a bit unusual though. However, if we zoom out the issue we see that we already version binary files when versioning pictures (jpg, png, and others) for instance. There are even ".class" files in our repo (https://github.com/apache/cloudstack/blob/master/tools/appliance/convert/Convert.class). I would be ok with this change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
