rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158232644
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -80,7 +80,7 @@ def configure_server(self):
# DNS search order
if gn.get_dns() and device:
sline = "dhcp-option=tag:interface-%s-%s,6" % (device, idx)
- dns_list = [x for x in gn.get_dns() if x is not None]
+ dns_list = [x for x in gn.get_dns() if not (not x)]
Review comment:
Fixed, I was trying to fix something that required `x` not be empty or None,
I check again a simple `if x` works :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
