rafaelweingartner commented on a change in pull request #2146: CLOUDSTACK-4757:
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158599641
##########
File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##########
@@ -192,6 +194,10 @@
+ " Example:
dhcpoptionsnetworklist[0].dhcp:114=url&dhcpoptionsetworklist[0].networkid=networkid&dhcpoptionsetworklist[0].dhcp:66=www.test.com")
private Map dhcpOptionsNetworkList;
+ @Parameter(name = ApiConstants.DATADISK_OFFERING_LIST, type =
CommandType.MAP, since = "4.10", description = "datadisk template to
disk-offering mapping;" +
+ " an optional parameter used to create additional data disks from
datadisk templates; can't be specified with diskOfferingId parameter")
+ private Map dataDiskTemplateToDiskOfferingList;
Review comment:
It is always time to create new patterns :)
I would suggest using a qualifying name that describes the true object.
Also, a documentation; for instance, this is a map of maps. What is the first
key that maps an entry to a map? What is the second key that maps a value?
After having this information we can even question, do we need a map of maps
structure? It feels a pretty complicated solution....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
