rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey
based approach for reading 'ping' configua?
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158672111
##########
File path:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
##########
@@ -242,11 +239,11 @@ public boolean configure(final String name, final
Map<String, Object> params) th
}
protected int getPingInterval() {
- return PingInterval.value();
+ return ManagementServiceConfiguration.PingInterval.value();
}
protected long getTimeout() {
Review comment:
Since you've introduced a new `ManagementServiceConfiguration`, why not
refactor/move this method to the class and make it reusable across
server/codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
