rafaelweingartner commented on a change in pull request #2315: A comprehensive
solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r159873055
##########
File path:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java
##########
@@ -167,35 +170,62 @@ public boolean trackVmHostChange() {
@Override
public Pair<Boolean, Long> getCommandHostDelegation(long hostId, Command
cmd) {
Review comment:
Yes you are right!
I have seen people counting the return as a point for the final metric; but,
I am not sure yet if they count or not. In my view the decision point is in the
conditional that enabled the return to be executed and not in the return per se.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
