rafaelweingartner commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355674496 @mike-tutkowski thanks for the effort. I would still prefer a cleaner version though. This block of code is the case that it is better to start with the conditions that generate exceptions `!canHandleDest` and `!canHandleSrc`, and then you can create the normal flow without requiring to add it inside a conditional. Anyways as I said here previously, I understand if you guys do not have time and energy to improve this now. However, we should start paying more attention to these legacy codes that sometimes are badly structured.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
