mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357361340 @rhtyd An update with regards to the three XenServer test failures: **test_02_edit_template | Failure | 90.10 | test_templates.py**: I'm still looking into this one. I don't see off hand while this should behave differently from master with regards to this bit of logic. **test_change_service_offering_for_vm_with_snapshots | Failure | 293.60 | test_vm_snapshots.py**: I see there is new logic when changing the service offering of a stopped VM to invoke resizeVolume and pass in new performance values (i.e. min and max IOPS). resizeVolume was seeing that there is a VM snapshot and throwing an exception in this situation. I have changed the logic so that it doesn't do this when you are not looking to change the size of the volume in question. **test_07_resize_fail | Failure | 41.45 | test_volumes.py**: As a result of a change in logic in resizeVolume, we no longer check to see if you passed in a custom disk size when you specified a non-custom disk offering. Instead of silently performing another action (the code was just using the disk size of the new disk offering), I have changed the logic to throw an exception if you passed in a custom size with a non-custom disk offering.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
