rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-357636543 @rafaelweingartner you can read `test_vm_snapshots.py` for details, the test case tries to see how vm snapshot work when service offering is changed. It deploys a VM, takes a VM snapshot (without memory), eventually (performs cpu/memory check to verify the offering used) changes the service offering and then shuts the VM, and then reverts to the previously taken VM snapshot. It fails at that point, as the revertSnapshot facade tries to resize root disk volume per the disk offering (if any). I found the fix, rather embarassing -- for some reason the user VM dao have a caching problem, so if someones tries to immediately revert snapshot after shutting the VM down, it may appear to be `PowerOn` to CloudStack which is where the exception is thrown that fails the test, the following fixes the test failure: ``` --- a/test/integration/smoke/test_vm_snapshots.py +++ b/test/integration/smoke/test_vm_snapshots.py @@ -513,7 +513,8 @@ class TestChangeServiceOfferingForVmWithSnapshots(cloudstackTestCase): virtual_machine.stop(self.apiclient) except Exception as e: self.fail("Failed to stop VM: %s" % e) - + + time.sleep(30) # 8) Revert to VM Snapshot ``` With this change, the test passes: ``` === TestName: test_change_service_offering_for_vm_with_snapshots | Status : SUCCESS === ok Ran 1 test in 501.359s OK ``` Alright LTGM all the smoketest results, there is no blockers I know of so I'll cut RC1 now - @DaanHoogland @rafaelweingartner @mike-tutkowski and others.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
