rhtyd commented on issue #2433: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-361897799 FYI, centos7 package failed (blueorangutan gave false positive): ``` + bash -x package.sh -p noredist -o rhel7 -d centos7 + TARGETDISTRO= + SIM= + PACKAGEVAL= + RELEASE= + '[' -n -p ']' + case "$1" in + echo 'Packaging CloudStack...' Packaging CloudStack... + PACKAGEVAL=noredist + echo noredist noredist + '[' noredist == oss -o noredist == OSS ']' + '[' noredist == noredist -o noredist == NOREDIST ']' + PACKAGEVAL=noredist + shift 2 + '[' -n -o ']' + case "$1" in + echo 'Error: Unrecognized option' Error: Unrecognized option + usage + cat Usage: ./package.sh -d DISTRO [OPTIONS]... Package CloudStack for specific distribution and provided options. If there's a "branding" string in the POM version (e.g. x.y.z.a-NAME[-SNAPSHOT]), the branding name will be used in the final generated pacakge like: cloudstack-management-x.y.z.a-NAME.NUMBER.el7.centos.x86_64 ``` For several package/build scripts to continue to work, please don't remove the -o option, and keep changes in the package.sh script restricted to accepting the brand string only.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
