DaanHoogland commented on a change in pull request #2244: 
CLOUDSTACK-10054:Volume download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r165599968
 
 

 ##########
 File path: core/src/main/java/com/cloud/storage/template/QCOW2Processor.java
 ##########
 @@ -40,6 +40,11 @@
 
     private StorageLayer _storage;
 
+   @Override
+   public FormatInfo process(String templatePath, ImageFormat format, String 
templateName, long processTimeout) throws InternalErrorException  {
+     return process(templatePath, format, templateName);
 
 Review comment:
   this is not right. it closes the door for implementing this for KVM (and 
other below) If this is really not applicable for any format but the VMware/OVA 
bit it should not be on the generic interface.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to