sgoeminn commented on a change in pull request #2445: CLOUDSTACK-10218: fix for
forced network update in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166640325
##########
File path:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
##########
@@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network,
VirtualMachineProfile vm, D
HostVO nuageVspHost =
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
VspNetwork vspNetwork =
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(),
network);
- if (vm.getType() == VirtualMachine.Type.DomainRouter &&
vspNetwork.getVirtualRouterIp().equals("null")) {
+ boolean isUpgradeNetworkOffering = vm.getType() ==
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
Review comment:
@DaanHoogland if the old offering had a VR and the new has one as well; in
that case the broadcast uri does not need to be updated because the VR ip does
not change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
