nvazquez commented on a change in pull request #2456: [CLOUDSTACK-10293] Single
view network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#discussion_r168983543
##########
File path: ui/scripts/vpc.js
##########
@@ -436,6 +401,38 @@
isOptional: true,
isEditable: true
},
+ 'icmptype': {
+ edit: true,
+ label: 'ICMP.type',
+ desc: 'Please specify -1 if you want to allow all ICMP types',
Review comment:
How about adding internationalization to desc field? (the same for icmpcode
below)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
