rafaelweingartner commented on a change in pull request #2464: [4.11] CLOUDSTACK-10299: UI: fix error in network listing in project mode URL: https://github.com/apache/cloudstack/pull/2464#discussion_r169496341
##########
File path: ui/scripts/network.js
##########
@@ -3537,28 +3535,28 @@
var lbID =
data.createloadbalancerruleresponse.id;
var inputData = {
- id:
data.createloadbalancerruleresponse.id
- };
-
+ id:
data.createloadbalancerruleresponse.id
+ };
+
var selectedVMs =
args.itemData;
if (selectedVMs !=
null) {
var
vmidipmapIndex = 0;
- for (var
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {
+ for (var
vmIndex = 0; vmIndex < selectedVMs.length; vmIndex++) {
var
selectedIPs = selectedVMs[vmIndex]._subselect;
for
(var ipIndex = 0; ipIndex < selectedIPs.length; ipIndex++) {
inputData['vmidipmap[' + vmidipmapIndex + '].vmid'] = selectedVMs[vmIndex].id;
-
+
if (args.context.ipAddresses[0].isportable) {
-
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] =
selectedIPs[ipIndex].split(',')[1];
+
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] =
selectedIPs[ipIndex].split(',')[1];
} else {
inputData['vmidipmap[' + vmidipmapIndex + '].vmip'] =
selectedIPs[ipIndex];
}
-
+
vmidipmapIndex++;
- }
+ }
}
- }
-
+ }
+
/*$.ajax({
Review comment:
You have gone over some commented code. What about removing it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
