DaanHoogland commented on a change in pull request #2472: CLOUDSTACK-10310 Fix 
KVM reboot on storage issue
URL: https://github.com/apache/cloudstack/pull/2472#discussion_r171781559
 
 

 ##########
 File path: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/KVMHAMonitor.java
 ##########
 @@ -115,22 +115,33 @@ protected void runInContext() {
                     }
 
                     String result = null;
-                    for (int i = 0; i < 5; i++) {
+                    // Try 3 times, but sleep in between tries to ensure it 
isn't a short lived transient error
+                    for (int i = 1; i <= 4; i++) {
 
 Review comment:
   the comment says try three times but i count 4 iterations. either the 
comment or the loop-control needs to change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to